Methinks the "T" section of the docs needs updating
-
Not sure what category this should be in so feel free to move it.
I think the Gcode dictionary "T" section https://duet3d.dozuki.com/Wiki/Gcode#Section_T_Select_Tool needs updating. I seem to recall that a limit of 50 tools was imposed at some version 3 firmware but this is not mentioned in the above linked documentation. In fact, there is this (quote) .......
"Selecting a non-existent tool (100, say) just does..........."
and this (quote)........
"Tool numbering starts at 0 by default however M563 allows the user to specify tool numbers, so with them you can have tools 17, 99 and 203 if you want. Negative numbers are not allowed."
So methinks that if there is indeed a limit of 50 tools, then those two statements are incorrect and a note needs to be added regarding the limit.
-
@deckingman thanks! i have updated the documentation.
-
@deckingman @T3P3Tony
I thought we could assign toolnumbers in non consecutive order, so there is a chance to have max. 50 tools in total, but numbered them in classes. (eg. CNC milling: probe tools from #0 to #9; flat head from #10 to #99 and radius tools from #100 to #199 etc)
Although the fact, that we can also assign toolnames makes this kind of classes obsolete -
@o_lampe said in Methinks the "T" section of the docs needs updating:
@deckingman @T3P3Tony
I thought we could assign toolnumbers in non consecutive order, so there is a chance to have max. 50 tools in total, but numbered them in classes. (eg. CNC milling: probe tools from #0 to #9; flat head from #10 to #99 and radius tools from #100 to #199 etc)
Although the fact, that we can also assign toolnames makes this kind of classes obsoleteI'm not sure what the rule on numbering is. Knowing the reason why the limit was imposed (to simplify the coding) , I suspect that we can only use numbers from 0 to 49 but we need @dc42 to confirm or otherwise.
-
@deckingman the reason for the limit on max tool number is so that RRF can report the tools in the object model as an array without the array becoming stupidly large.
-
@dc42 said in Methinks the "T" section of the docs needs updating:
@deckingman the reason for the limit on max tool number is so that RRF can report the tools in the object model as an array without the array becoming stupidly large.
it's not my field of expertise by any means but I seem to recall that over on "slack" when it was discussed, Chris Hamm and Manuel said that an array wasn't needed. It had something to do with pairs of values but I didn't really understand what they were talking about.
-
@deckingman we could have returned an array that was not indexed by tool number, but that would have made retrieving values for a given tool number more difficult for users writing conditional GCode, because you would need to search the array for the tool with the right number first. Worse, another GCode channel could insert or delete tools while you were searching it.
-
@dc42 said in Methinks the "T" section of the docs needs updating:
@deckingman we could have returned an array that was not indexed by tool number, but that would have made retrieving values for a given tool number more difficult for users writing conditional GCode, because you would need to search the array for the tool with the right number first. Worse, another GCode channel could insert or delete tools while you were searching it.
Fair enough. Am I right in saying that tool numbers can inly be in the range 0 to 49?
-
@dc42 said in Methinks the "T" section of the docs needs updating:
the reason for the limit on max tool number is so that RRF can report the tools in the object model as an array without the array becoming stupidly large.
I'm less concerned about the object model, but how the mainpage of DWC would look like with 49 tools? Some sort of pop up subtree arrangement would be handy. (classes of tools as above mentioned)
-
@deckingman said in Methinks the "T" section of the docs needs updating:
Fair enough. Am I right in saying that tool numbers can inly be in the range 0 to 49?
Yes.
-
@o_lampe said in Methinks the "T" section of the docs needs updating:
............. I'm less concerned about the object model, but how the mainpage of DWC would look like with 49 tools? Some sort of pop up subtree arrangement would be handy. (classes of tools as above mentioned)
I can confirm that it looks a mess with a mere 11 tools and I wish I could hide or somehow minimise them. I'd love to see each section of DWC in a separate window which can be un-docked, moved, resized, or minimised in similar fashion to how my video editing package (Vegas Pro) works. Or even better to be able to create one's own dashboard views from scratch the way that HomeAssistant works with something called "LoveLace".