Why does RRF3Common live in CANlib?

oliof

Hi,
spelunking through code I found RRF3Common.[h|cpp] living in CANlib. It starts with the following comment:

/*
 * RRF3Common.h
 *
 *  Created on: 17 Oct 2021
 *      Author: David
 *
 *  This file contains definitions common to all implementations of RRF3 on Duets, including those that don't support CAN
 */

Purely out of curiosity, why do these files reside with CANlib and not some other place like RRFLibraries?

dc42

@oliof RRFLibraries is a true library project, used not only by RRF but now also by PanelDueFirmware. Whereas CANlib is used only by RRF and Duet3Expansion. So CANlib was a more obvious location to define constants that for Duet 3 need to be visible to Duet 3 expansion board firmware as well as to the RRF project.