[3.3RC3] tool change don't wait on M116 P

dc42

@psychotik2k3 please can you put together the simplest example you can that exhibits this behaviour. I can't make it happen on my printers,

psychotik2k3

@dc42 here it is:

var toolnumber = 1
var targettemp = 60
G28
if sensors.gpIn[1].value=0
    T-1 P0
else
    T-1
	
G10 P1 S{var.targettemp} R0
G10 P2 S{var.targettemp} R0
G4 P50
T1
G0 X155 Y155
M400
T2
G0 X155 Y155
M400
T-1
G10 P{var.toolnumber} S0 R0

if i perform a reset of the board this will fail 99.5%
but if i launch it a second time ia may or may not fail.

here is a video showing how it behaves and you clearly see that tools are moving while they are not at the correct temp
youtube video

psychotik2k3

@dc42 if you want somehting else here is my whole sys macro and gcode folder:
github BLV MGN Seb for duet 3

dc42

@psychotik2k3 thanks. When M116 Pn fails to wait for the heaters on tool n to heat up, is the heater concerned always one that is attached to the main board; or always one attached to an expansion board; or have you seen both?

psychotik2k3

@dc42 no all my tool heaters are attached to the H3C

i attached the XY and Z, bltouch part cooling fan and heatbed on the mainboard, and everything related to the tools (heater thermistor stepper and fan) on H3C board.

so to sum up:
heater 0 and its thermistor (heatbed) on MB6HC
heaters 1 to 2 (tools) and their themistors on H3C

(i just added that because maybe this is because i have no tool on mainboard but still one heater the heatbed)

dc42

@psychotik2k3 thanks. Please can you try putting a G4 S1 command immediately before the M116 P1 command in tpost1.g and see if that works around the problem.

psychotik2k3

@dc42 it worked
i wouldn't have bet on it as we already test a G4 P50 before the call to the tool.
but it worked.
do i have to try back with rrf3.3rc3+1? or does some modifications included in the rc3+6 are still needed to make it works ?

dc42

@psychotik2k3 I don't think any of the other changes are needed. I think the issue may occur when selecting the new tool turns its heater on, and the heater is on a remote board, and the main board hasn't received a status report from that board between turning the heater on and the M116. I will try to implement a fix in time for the imminent 3.3 stable release.

psychotik2k3

@dc42 at least the workaround is easy and can be implemented in the config.
but thanks for your efforts.
finally succeeded to print with 2 heads: (don't bother the crappy one i had broken filament and had to insert and push manually)

kingofthegeeks

@dc42 Thank you for this sir, I was getting quite frustrated.

dc42

@psychotik2k3 @kingofthegeeks this issue should be fixed in the new firmware builds at https://www.dropbox.com/sh/xfsvscbaab0dtzl/AACCcSeiTNINZL-xbs6IhC4Ja?dl=0. Ignore the .map files.

psychotik2k3

@dc42 ok will try and tell you.

kingofthegeeks

@dc42 can confirm.

dc42

@kingofthegeeks thanks!

psychotik2k3

@dc42 couldn't test as i performed some long prints. but yes it works.
thanks for your hard work.