File seems to crash the firmware (Maybe Line Endings?)

[dgrat]

I noticed that the firmware/WebApp seems to crash if I upload and execute this file.
Copying the content with Notepad++ into a new file seems to work.

lin_adv.gcode

[dc42]

@dgrat the line ending shouldn't matter. Which board and firmware version are you using?

[dgrat]

@dc42

Board: Duet 2 WiFi (2WiFi)
Firmware: RepRapFirmware for Duet 2 WiFi/Ethernet 3.4.1 (2022-06-01)
Duet WiFi Server Version: 1.26

[dgrat]

@dgrat
I think it might be the coding. I was piping the output of a python script with powershell. Maybe a coding check (warning) in the web-app or firmware would be beneficial.

[dc42]

@dgrat yes, that file is UTF16 encoded. RRF only accepts UTF8 and plain ASCII.

[chrishamm]

@dgrat In SBC mode it may be possible to use UTF-16 files because the file readers should auto-determine the underlying encoding. I have not tested this yet, though.

[dgrat]

Do you think it makes sense to check encoding in the firmware and reject the file to avoid UB.