[3.5.b1] Loading filament via DWC does not work

Diamondback

Not sure why exactly, but when I try to load a filament via the DWC filament feature, it doesn't work anymore in 3.5b1. It executes a bunch of code in my load macro, but then suddenly gets stuck after displaying a message box that I need to ack. The printer then just gets stuck in Busy state until I manually reset it.

Any ideas?

Here's a typical load macro:

var extrusionTemp = var.T
var extrusionMinTemp = var.S
var retractionMinTemp = var.R
set global.pebbleFeedSpeed = var.F ;apply commanded pebble feed speed

M98 P"/macros/Misc/Lights/On"
M291 P"Heating for purge" R"Filament" S0 T5
M98 P"/macros/Toolchanging/HomeIfNotHomed"
M568 P{state.currentTool} S{var.extrusionTemp} R0
M116 P{state.currentTool}
M302 S{var.extrusionMinTemp} R{var.retractionMinTemp}         	;Cold extrusion settings
M98 P"/macros/Misc/Beep"
M291 P"Ready to load new filament?" R"Filament" S2
G4 S2
G1 E75
M98 P"/macros/Tool/Purge"
M98 P"/macros/Tool/Cooldown"
M98 P"/macros/Misc/Beep"

As far as I can tell, it executes things corretly until after the M291 S2 (line 13), but none of the following stuff is ever executed.

Diamondback

Update: This seems to be a DWC issue, downgrading the firmware to 3.4.5 while leaving DWC at 3.5b1 did NOT solve the problem, only downgrading DWC to 3.4.5 as well helped.

Diamondback

@chrishamm maybe? I can successfully use RRF 3.5b1 with 3.4.5 DWC, but with 3.5b1 DWC it fails.

chrishamm

@Diamondback I believe this is caused by the blocking message box. I am investigating.

chrishamm

@chrishamm Yes, it's the message box handling. Currently you can work-around this bug by sending M292 only using the DWC input, although I understand it isn't ideal. The corresponding bug fix will be part of 3.5-b2.

Diamondback

Awesome, thank you. Is the duplication in the check from this commit the culprit?
https://github.com/Duet3D/DuetWebControl/commit/8b9c4ef816f5559e56c324625336deb0c43c963e

0

chrishamm committed to Duet3D/DuetWebControl

Fixed behaviour for non-blocking message boxes

chrishamm

@Diamondback Yes, it is. Stupid typo.

Diamondback

@chrishamm Oh well, it happens Not the first time, not the last time