Duet3D Logo Duet3D
    • Tags
    • Documentation
    • Order
    • Register
    • Login

    Bug? - CombineName() Buffer Overflow - Web Control 1.20

    Scheduled Pinned Locked Moved
    Duet Web Control wishlist
    2
    4
    650
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • webdadundefined
      webdad
      last edited by

      Did a complete 1.20 (firmware, DuetWiFi, and DWC) upgrade over the weekend. Everything seems to be working well. The only thing I've discovered is a CombineName() Buffer Overflow error when attempting to upload, what I presume, is a file name that is too long.

      See the quick screen shot I was able to grab. Granted, my naming was a bit verbose, and I was able to successfully upload once I dropped the spaces and some extraneous verbiage.

      1 Reply Last reply Reply Quote 0
      • dc42undefined
        dc42 administrators
        last edited by

        The maximum length of a filename including the path is set at 100 characters in the firmware.

        Duet WiFi hardware designer and firmware engineer
        Please do not ask me for Duet support via PM or email, use the forum
        http://www.escher3d.com, https://miscsolutions.wordpress.com

        1 Reply Last reply Reply Quote 0
        • dc42undefined
          dc42 administrators
          last edited by

          For the next firmware release I have increased the maximum to 120 characters on the series 2 Duets, also I have changed the error message to "file name too long".

          Duet WiFi hardware designer and firmware engineer
          Please do not ask me for Duet support via PM or email, use the forum
          http://www.escher3d.com, https://miscsolutions.wordpress.com

          1 Reply Last reply Reply Quote 0
          • webdadundefined
            webdad
            last edited by

            Thanks, anyway to fail the start of the upload if the name is too long? The first time the upload success msg stayed and the error message flashed by and then the file wasn't shown on site. I had to do it 2 other times, once to read the message, and the next to capture the msg.

            1 Reply Last reply Reply Quote 0
            • First post
              Last post
            Unless otherwise noted, all forum content is licensed under CC-BY-SA