How to submit code changes for consideration

MichaelM

Hello,

I modified the PanelDue firmware to have a "WiFi Settings" dialog that allows the user to enter the SSID and password for their network. When they press Enter the specified SSID and Password is embeded in a M587 command. The intent is to make it easier for an end user to configure the WiFi settings of the DuetWiFi.

I would like to submit these changes for consideration to be added to the root code.

How do I go about doing this?

Thanks,
Mike

gtj0

Your best bet is to submit a pull request at
https://github.com/dc42/PanelDueFirmware

MichaelM

The Pull request button is disabled. I suspect since I do not have write access? Or maybe I need to make a branch first?

MichaelM

I made progress. Should I create a fork and upload to the fork?

MichaelM

I think I submitted a pull request. It would be from MichaelM4.

dc42

Thanks, I'll take a look at it when I start work on the next major PanelDueFirmware release.

MichaelM

Hello,

Did you find and look over the code changes I submitted?

Thanks,
Mike

dc42

I'm sorry, I can't see your pull request at https://github.com/dc42/PanelDueFirmware/pulls.

MichaelM

I must have done it wrong. You can see the code here

https://github.com/MichaelM4/PanelDueFirmware