Navigation

    Duet3D Logo

    Duet3D

    • Register
    • Login
    • Search
    • Categories
    • Tags
    • Documentation
    • Order

    Pull request for FtpResponder bug

    Firmware developers
    2
    4
    260
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • gtj0
      gtj0 last edited by gtj0

      @dc42 I just created a pull request against v3-dev for an FtpResponder issue.

      It wasn't initializing haveCompleteLine to false so when the first client connected to a responder, the responder would immediately return "500 Unknown login command" and cause some clients to barf.

      https://github.com/dc42/RepRapFirmware/pull/295

      gtjoseph created this issue in dc42/RepRapFirmware

      closed FtpResponder: Initialize haveCompleteLine to false #295

      1 Reply Last reply Reply Quote 0
      • dc42
        dc42 administrators last edited by

        Thanks for spotting this! I'm fixing it in RRF 2.03RC5 in a slightly different way (initialising it in FtpResponder::Accept instead), and this fix will be propagated to RRF 3 when I merge the 2.03RC5 changes into it later this week.

        1 Reply Last reply Reply Quote 0
        • gtj0
          gtj0 last edited by

          Good deal! Feel free to close that pull request if you don't need it.

          1 Reply Last reply Reply Quote 0
          • dc42
            dc42 administrators last edited by

            Thanks, I'll close it then.

            1 Reply Last reply Reply Quote 0
            • First post
              Last post
            Unless otherwise noted, all forum content is licensed under CC-BY-SA