[3.4rc1] Issue with M291 in start.g

oozeBot

@chrishamm There are no errors in the JS console. As far as "looking normal", the snippet below sticks out to me. It knows it's waiting on acknowledgement, but the message box is never displayed.

I just did another test. I simply ran M291 S3 R"Test" P"Test" from the "Send Code.."box across the top. It resulted in the same results - the system is stuck in busy with no messagebox displayed.

edit - this was tested in both Chrome and Edge with the same results.

If you can think of any other test you'd like me to perform, I have a machine free specifically for testing. Thanks

=== Duet Control Server ===
Duet Control Server v3.4-rc1
HTTP:
Waiting for acknowledgement, requested by M291 S3 R"Turn off power?" P"Are you sure you want to turn off power?"
> Next stack level
Executing macro 0:/macros/test3.g, started by M98 P"0:/macros/test3.g"

chrishamm

@oozebot Can you please downgrade RRF to 3.4-b7 and check if the message boxes work then? I am not aware of any change that could break this feature and being unable to reproduce it myself doesn't make it any easier.

oozeBot

@chrishamm @dc42 - reverting to RRF 3.4b7 resolves the issue. The message boxes are properly displaying.

dc42

@oozebot are you able to temporarily run that test machine in standalone mode using 3.4rc1+2 and see whether the issue still occurs?

PS - here's another test you can do. Connect a PC running YAT or another terminal emulator to USB. Send this command to it:

m409 k"state.messageBox"

It should return:

{"key":"state.messageBox","flags":"","result":null}

Now run a macro containing the code snippet you posted. When the message box is supposed to be displayed, send the M409 command via USB again. This time it should respond:

{"key":"state.messageBox","flags":"","result":{"axisControls":0,"message":"Are you sure you want to turn off power?","mode":3,"seq":7,"timeout":0,"title":"Turn off power?"}}

Sending M292 will clear the result back to null. The "seq" value in the response should increment each time you run the macro.

MaxGyver

@dc42

I ran the test, but since I am using an SBC I was unable to run a macro. Sending the M291 from the terminal did not return the expected response.

M115
FIRMWARE_NAME: RepRapFirmware for Duet 3 MB6HC FIRMWARE_VERSION: 3.4.0rc1+2 ELECTRONICS: Duet 3 MB6HC v0.6 or 1.0 FIRMWARE_DATE: 2022-02-17 15:38:02<LF>ok<LF>
m409 k"state.messageBox"
{"key":"state.messageBox","flags":"","result":null}<LF><LF>ok<LF>
M291 S3 R"Turn off power?" P"Are you sure you want to turn off power?"
- Turn off power? -<LF>Are you sure you want to turn off power?<LF>Send M292 to continue or M292 P1 to cancel<LF>ok<LF>
m409 k"state.messageBox"
{"key":"state.messageBox","flags":"","result":null}<LF><LF>ok<LF>

MaxGyver

@dc42 @chrishamm

I just switched to standalone mode. Here, M291 works flawless.

dc42

@maxgyver said in [3.4rc1] Issue with M291 in start.g:

@dc42 @chrishamm

I just switched to standalone mode. Here, M291 works flawless.

Thanks, that's useful information.

oozeBot

@maxgyver - Thank you for testing this. We had it on our agenda to test this morning..

@dc42 - Please let us know if there is anything else you need us to test as we have a dedicated test machine.

dc42

@oozebot please can you try downgrading RRF only (not DWC or DSF) to 3.4.0beta7, and see if the problem still occurs. You should be able to do that by uploading the firmware binary through DWC, and then running M997 if it doesn't prompt you to install it.

oozeBot

@dc42 - maybe you missed my response to this on Friday. Only RRF was downgraded.

@oozebot said in [3.4rc1] Issue with M291 in start.g:

@chrishamm @dc42 - reverting to RRF 3.4b7 resolves the issue. The message boxes are properly displaying.

dc42

@oozebot thanks. Can you conform that you were using the latest DWC build (later than the rc1 build) when you ran this test?

dc42

@MaxGyver @oozeBot please try the new Duet3Firmware_MB6HC.bin at https://www.dropbox.com/sh/2dt7sbqpx6l74np/AADn4-lpcil1iqnWKkiVri3Ia?dl=0.

oozeBot

@dc42 It appears to be working in 3.4.0rc1+3, however, we'll keep testing and report back with any issues. Thanks!

oozeBot

@dc42 While M291 is now working in 3.4.0rc1+3, the prompt has stopped showing up on the PanelDue (3.4.1-pre1). With 3.4.0rc1, the prompt was only displaying on the PanelDue.. We'll do some more testing, but this can be reproduced pretty easily.

oozeBot

The reported M291 issue within DWC appears to be resolved with the pre-release provided earlier today. The issue with the message box displaying on the PanelDue appears to be intermittent and independent of this issue.

MaxGyver

@dc42

I am happy to confirm that on RRF 3.4 rc1+3 +SBC and Duet Web Control 3.4.0-rc2pre the issue with M291 seems to be resolved.

Thanks!
-Max