FTP does not properly respond to "LIST -a"

[adambx]

I am using wget to download files from the SD Card using FTP. worked so far for 3.4, but has stopped working in 3.5.
After some research it turns out that the newly introduced feature of supporting LIST <dir> does not take into account the -a flag that is sent by many FTP clients including wget.

there is a discussion here:
https://savannah.gnu.org/bugs/?59954

The relevant change is here. Should an error be returned on LIST -a?
https://github.com/Duet3D/RepRapFirmware/commit/7e11027b22a0720d756369393bf96d94a2c01b9a#diff-1608ecf6e91dd6a71fa80c16d6c79cc2e79f5b6ed17ab92a97b8fd8de96d1dd4R675-R678

i guess if an error is returned, wget will retry with "LIST", that's the usual behaviour.

debug output of wget looks like this:

230 Login successful.
Logged in!
==> SYST ...
--> SYST

215 UNIX Type: L8
done.
UNIX TYPE L8: I know it and I will use "LIST -a" as standard list command

Cheers
Adam

0 dc42 committed 16 Feb 2023, 09:16 to Duet3D/RepRapFirmware

Support the directory parameter in the FTP LIST command

[droftarts]

@adambx thanks for reporting this, I’ll mark it for the attention of @dc42.

Ian

[dc42]

@adambx if I provide you with a new RRF binary, can you test it? Which Duet are you using?

PS - I created https://github.com/Duet3D/RepRapFirmware/issues/882.

dc42 created this issue 18 Jul 2023, 09:47 in Duet3D/RepRapFirmware

closed FTP server doesn't support LIST -a nor does it return an error #882

[dc42]

@adambx we are closing this issue because you have not responded.

[chrishamm]

@adambx @dc42 I can confirm the latest firmware version works with wget and LIST -a.