Duet3D Logo

    Duet3D

    • Register
    • Login
    • Search
    • Categories
    • Tags
    • Documentation
    • Order

    Solved Release 2.02RC5 issue: resume: drivesRelative and axesRelative

    Firmware installation
    2
    3
    297
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • resam
      resam last edited by

      Maybe not a new issue, but related to the recent discussion around resume.g:

      gb.MachineState().drivesRelative and gb.MachineState().axesRelative should IMO be set to the state they were before pausing. SaveResumeInfo already does so by writing it to the resurrect file. RestorePoint needs new members to keep track of them.

      Somewhere around here?
      https://github.com/dc42/RepRapFirmware/blob/a15773859dabee6e88cce157f7c00d17e29171b4/src/GCodes/GCodes.cpp#L763

      I suppose one could make a bigger argument about which machine settings / states should be restored, and which should not, e.g., relative/absolute movement sounds important to me, fan configuration and drive mappings probably not. etc.

      We should at least document the list of actions and settings in the wiki...
      @dc42 any thoughts on the grand scheme of things?

      1 Reply Last reply Reply Quote 0
      • dc42
        dc42 administrators last edited by

        That's not necessary. Each input channel has its own absolute/relative state. When you resume the SD card print, it will revert to the absolute/relative state associated with the SD card input channel, which will be the same as when it was paused. Any G90/91 or M82/83 commands that you send from other channels while the print is paused will only affect commands sent form that channel.

        Duet WiFi hardware designer and firmware engineer
        Please do not ask me for Duet support via PM or email, use the forum
        http://www.escher3d.com, https://miscsolutions.wordpress.com

        1 Reply Last reply Reply Quote 0
        • resam
          resam last edited by

          Sounds good - thanks for the explanation!

          1 Reply Last reply Reply Quote 0
          • First post
            Last post
          Unless otherwise noted, all forum content is licensed under CC-BY-SA