Configurator not respecting ActiveHigh/ActiveLow for endstops

[keyz182]

On https://configtool.reprapfirmware.org/ when selecting Active High for endstops:

; Endstops
M574 X1 S1 P"xstop"                            ; configure active-high endstop for low end on X via pin xstop
M574 Y1 S1 P"ystop"                            ; configure active-high endstop for low end on Y via pin ystop

When selecting Active Low:

; Endstops
M574 X1 S0 P"xstop"                            ; configure active-low endstop for low end on X via pin xstop
M574 Y1 S0 P"ystop"                            ; configure active-low endstop for low end on Y via pin ystop

Unless I'm misunderstanding, it should be M547 X1 S0 P"!xstop" - is that correct?

[dc42]

@keyz182 said in Configurator not respecting ActiveHigh/ActiveLow for endstops:

Unless I'm misunderstanding, it should be M547 X1 S0 P"!xstop" - is that correct?

Yes, for RRF 3.1.x that is correct.
For RRF 3.1 it should be: M547 X1 S1 P"!xstop"

[keyz182]

@dc42 said in Configurator not respecting ActiveHigh/ActiveLow for endstops:

@keyz182 said in Configurator not respecting ActiveHigh/ActiveLow for endstops:

Unless I'm misunderstanding, it should be M547 X1 S0 P"!xstop" - is that correct?

Yes, for RRF 3.1.x that is correct.

It also had the "S" parameter wrong, so should be M574 Y1 S1 P"!ystop".