tool off and bed off inconsistency - DWC 3.4b7
-
When setting a tool to off in DWC, the temperature is reduced from whatever was set to 0.
When setting a bed to off in DWC, the temperature remains at whatever temperature it was set to.
@chrishamm -
@jay_s_uk DWC currently sends
G10 Pnnn S-273.15 R-273.15to turn off a tool, although that is about to be changed toM568 Pnnn A0. So RRF actually resets the active/standby temps to 0, not DWC. -
@chrishamm ah, ok. so how come it doesn't do the same for bed?
-
@jay_s_uk See https://github.com/Duet3D/RepRapFirmware/blob/3.4-dev/src/Tools/Tool.cpp#L622, not sure why the behaviour is different.
@dc42 what do you think, should we change either M140/141 or G10?
-
@chrishamm Please also note this related wish: https://forum.duet3d.com/topic/26563/allow-m144-to-turn-off-the-bed-heater. Decoupling temperature setting from active-standby-off state changes could make the handling of bed and tool heater states less inconsistent.
Also, using zero to signify "no heat" is perhaps not the best. What would happen to someone building a machine for ice cream extrusion...?
You might use, e.g., -273.15 to signify "no temp set" in the object model, and display it as "None" in DWC, thus avoiding zero as a magic number.
-
Personally, I've never seen the point of having a standby temperature for the bed, and I would prefer to get rid of it.
