Wrong number in heater faults in 3.4

[achrn]

On my MB6HC firmware 3.4.0 reports the wrong heater number in heater faults.

If heater 1 or 2 fault, the console message is that "Error: Heater 0 fault: ..." and the param-D passed to heater-fault.g appears to be zero.

For example, this is a fault occurring on my heater 2:

My heater-fault.g just reports param D :

echo "heater fault"
echo {param.D}

Board: Duet 3 MB6HC (MB6HC)
DSF Version: 3.4.0
Firmware: RepRapFirmware for Duet 3 MB6HC 3.4.0 (2022-03-15)
Attached SBC (Pi4)

[dc42]

@achrn thanks, on my list to look into.

[dc42]

I have fixed this in the source code. The fix will be in 3.5.0beta1 and also in 3.4.1 if we do that release. The actual fault was that the CAN address and device number parameters were swapped.

[achrn]

@dc42 Thanks. I'm not using any addon boards (it's just a MB6HC plus Pi) , does the fix still apply?

[dc42]

@achrn yes, in fact the fix only applies to heaters connected to the main board. Heaters connected to CAN-connected expansion boards generate the correct event,