Command to move/rename files

wilriker

Currently there are only two ways to move or rename a file: use DWC (which is using an HTTP call underneath) or remove the SD card from the Duet and do it on a computer.

I propose an M-Code command to do the same. Looking at https://reprap.org/wiki/G-code there is nothing unused in the M20..M39 range but at least RRF is not using M31 so far.

Is there any reason why there is not command available for this task already?

Background of this request: DWC2 so far lacks the capability of moving files to other folders. So to move files one has to either fall back to DWC1 or use the computer. Using an M-Code would make this easier IMHO. Also I see use-cases where you could use macros to rename files (e.g. various configurations swapping in and out)

As most of the times I am willing to implement this and sent a PR for it if this request is accepted.

dragonn

Yeah, that would be really great for swapping configuration without using "g-code programming" with will be in 2.03. And even on 2.03 that would be useful

Dougal1957

@wilriker You could also use an FTP Session to do this! assuming you enable FTP Support that is.
Configure Network Protocols

Doug

wilriker

@dougal1957 Yeah, that would work, too. But I think "G-Code everywhere" should allow such a simple task. Also everything in source code is already present it just needs an outside interface.

dc42

Please check whether anything else uses M31 already, in particular the NIST CNC GCode standard and Marlin.

wilriker

@dc42 Marlin does use M31 to report current print time.

The next unused M-Code according to https://reprap.org/wiki/G-code is M50. This is not used by Marlin or NIST CNC. It is though used by LinuxCNC and ReplicatorG according to a short research.

Danal

M31 is "time since start of SD print" on Marlin and many others.

Perhaps, extend M33 instead. This is "get long name of file" in Marlin (and others) today.

https://reprap.org/wiki/G-code

dc42

@wilriker said in Command to move/rename files:

@dc42 Marlin does use M31 to report current print time.

The next unused M-Code according to https://reprap.org/wiki/G-code is M50. This is not used by Marlin or NIST CNC. It is though used by LinuxCNC and ReplicatorG according to a short research.

In that case I suggest we allocate an unused (by RRF/NIST/Marlin) M-code in the 500 range or possibly the M400 range, assuming that M33-M35 are already taken (I expect they are, because I allocated M36).

wilriker

@dc42 said in Command to move/rename files:

In that case I suggest we allocate an unused (by RRF/NIST/Marlin) M-code in the 500 range or possibly the M400 range, assuming that M33-M35 are already taken (I expect they are, because I allocated M36).

I need to check on NIST but M470 is looking good so far. Will allocate it tomorrow then and provide a PR.

dragonn

Will it support renaming folders too?

wilriker

@dragonn said in Command to move/rename files:

Will it support renaming folders too?

That's the plan.

Also I just coincidentally stumbled across a request of the same feature by @resam that also asked for a way to create a directory via GCode. I will also allocate a M-Code for that and include it in my PR. Both a fairly trivial to do.

3dmntbighker

@wilriker said in Command to move/rename files:

Currently there are only two ways to move or rename a file: use DWC (which is using an HTTP call underneath) or remove the SD card from the Duet and do it on a computer.

I propose an M-Code command to do the same. Looking at https://reprap.org/wiki/G-code there is nothing unused in the M20..M39 range but at least RRF is not using M31 so far.

This ties into my suggestion that files with "._" and ".DS_Store" should at the very least be hidden. For that matter any file that starts with a period should really be ignored. Anyone who frequently mounts the SD card in Windows or Mac will likely find these droppings all over the place. I'd be just as happy if the Duet deleted all of these files when the SD card is mounted, but I realize that's not likely to happen. I'm mostly referring these files appearing in the 12864 file list.

wilriker

I reserved M470 for creating a directory and M471 for moving/renaming files/directories. PR with implementation somewhen later today.

dc42

@3dmntbighker said in Command to move/rename files:

This ties into my suggestion that files with "._" and ".DS_Store" should at the very least be hidden. For that matter any file that starts with a period should really be ignored. Anyone who frequently mounts the SD card in Windows or Mac will likely find these droppings all over the place. I'd be just as happy if the Duet deleted all of these files when the SD card is mounted, but I realize that's not likely to happen. I'm mostly referring these files appearing in the 12864 file list.

I am confused. RRF doesn't return files whose name begin with '.' to DWC. I have just tested this by uploading a menu file starting with '.' to a Maestro. It didn't appear in the file list after uploading it, even after pressing Refresh.

wilriker

And here's the Pull Request.

3dmntbighker

@dc42 said in Command to move/rename files:

@3dmntbighker said in Command to move/rename files:

This ties into my suggestion that files with "._" and ".DS_Store" should at the very least be hidden. For that matter any file that starts with a period should really be ignored. Anyone who frequently mounts the SD card in Windows or Mac will likely find these droppings all over the place. I'd be just as happy if the Duet deleted all of these files when the SD card is mounted, but I realize that's not likely to happen. I'm mostly referring these files appearing in the 12864 file list.

I am confused. RRF doesn't return files whose name begin with '.' to DWC. I have just tested this by uploading a menu file starting with '.' to a Maestro. It didn't appear in the file list after uploading it, even after pressing Refresh.

I was referring to what I see in the 12864 directory list. Not the web console. When you go to print from the 12864 menus there are a bunch of these files littered everywhere that Windows must have left at some point. But I use a Mac.

wilriker

@3dmntbighker said in Command to move/rename files:

a bunch of these files littered everywhere that Windows must have left at some point. But I use a Mac.

Just nitpicking: .DS_Store files are created by MacOS.

Solution: use Linux. It won't add any unwanted files to your SD card.

(Couldn't resist )

3dmntbighker

@wilriker said in Command to move/rename files:

@3dmntbighker said in Command to move/rename files:

a bunch of these files littered everywhere that Windows must have left at some point. But I use a Mac.

Just nitpicking: .DS_Store files are created by MacOS.

Solution: use Linux. It won't add any unwanted files to your SD card.

(Couldn't resist )

Hehe, I manage Linux systems for a living. But I use a Mac to get actual work done.

wilriker

@3dmntbighker Fair enough. I use Linux everywhere and wouldn't want it any other way. One of my professors once said to me it all boils down to what system fits best to your way of thinking and expectations.

deckingman

@wilriker said in Command to move/rename files:

@3dmntbighker Fair enough. I use Linux everywhere and wouldn't want it any other way. One of my professors once said to me it all boils down to what system fits best to your way of thinking and expectations.

For me, that would mean a slide rule and log tables