Error in generated ressurect.g file



  • I had my first power failure today, and was able to get recovery working with a little bit of effort. I noticed that the generated ressurect.g has a small error in it where it didn't put quotations around the file name when calling M23, so on resume it failed to find the file until I renamed it. At least I think it is for this reason.

    ; File "Tube 1 (PLA).gcode" resume print after power failure at 2019-04-20 19:34
    M140 P0 S60.0
    G10 P0 S200 R200
    T0 P0
    G29 S1
    G92 X146.044 Y181.025 Z140.000
    M98 Presurrect-prologue.g
    M106 P0 S0.00
    M106 P2 S1.00
    M106 S1.00
    M116
    M290 S0.080
    G92 E0.00000
    M83
    M23 Tube 1 (PLA).gcode
    M26 S11969350 P1.243
    G0 F6000 Z142.000
    G0 F6000 X146.044 Y181.025
    G0 F6000 Z140.000
    G1 F6000.0
    M24

    The result of this was that it tried to load "Tube 1 .gcode" dropping the filename at the '(' character.

    Additionally the "M290 S0.080" had an additive effect (as it would normally), so upon re-running M916 after renaming the file it finally succeeded but left a bit of a gap at the first layer until I fixed the stepping, it might be better to use "M290 S0.080 R1" in this case.



  • And, before I forget. Last released firmware here.

    Firmware Name: RepRapFirmware for Duet 2 Maestro
    Firmware Electronics: Duet Maestro 1.0
    Firmware Version: 2.02(RTOS) (2018-12-24b1)
    Web Interface Version: 1.22.6
    Web Interface by Christian Hammacher
    Licensed under the terms of the GPL v3


  • administrators

    Thanks for pointing these out. I have corrected the source code, so they will be fixed in the next release. It's R0 that needed to be added to the M290 command to set babystepping absolutely, not R1.

    M23 usually works without quotation marks around the file name, but perhaps not when the filename includes space characters.



  • You are absolutely right, R0 not R1! Sorry about that.

    Thanks though for the quick response.


 

Looks like your connection to Duet3D was lost, please wait while we try to reconnect.