3.3.0: Installing plugins

resam

@chrishamm I'm trying to install DSF plugins via DWC 3.3.0:

the SBC permissions in DWC seem to all start with a lower case letter and therefore reject an otherwise valid plugin.json. I followed the permission naming from https://github.com/Duet3D/DuetSoftwareFramework/blob/v3.3-dev/PLUGINS.md - but DWC has its own and different set here: https://github.com/Duet3D/DuetWebControl/blob/v3.3-dev/src/plugins/manifest.js#L66
Please make it the same, or accepts case-insensitive spellings.

The little popup window when you drag&drop a valid plugin zip to the "Upload & Start" button displays a nice summary. Please make the Website/Homepage field display the full URL - I tried to put my GitHub URL there and it got truncated to the root domain without URL paths.

Having an Illegal plugin identifier in plugin.json only causes a generic System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. I had to dig through the SBC system logs to figure out why it is failing.

jay_s_uk

@resam have you started to plugin service etc?
See here for instructions https://github.com/Duet3D/DuetSoftwareFramework/wiki/Changelog-DSF-3.x#version-330

resam

@jay_s_uk yes, I started it. I reported bugs - and their fix. So in the end I got a working system.

The case-insensitive spelling of SBC permissions needs to be fixed in DWC or the wiki.

The homepage/website URL would be a nice UX improvement for DWC.

The illegal plugin identifier is an unexpected error with a useless error message. This can be probably fixed in DCS.

Another thing I noticed or would like to suggest: when installing a plugin that already exists, it would be great to give some indication of what is going to happen. Will the old version of the plugin be fully uninstalled and removed? Will the new install create duplicate / second version? Is there even an older version present that will be replaced?

chrishamm

@resam Thanks for your feedback.

I'll change DWC to ignore the casing of the SBC permissions - DSF does not care about it either. For the meantime I've added a note to the plugin documentation.

When I designed the plugin wizard I found the full URL (especially when pointing to GitHub repos) way too long. That's why I decided to truncate it - it doesn't have a practical disadvantage either.

The plugin identifier check in DWC seems to permit spaces and dots which isn't right. I've fixed this as well so that particular error shouldn't show up in the next version at all. Nevertheless I'll investigate that rather useless exception message, I would've expected it report something like Illegal plugin identifier instead.