Duet3D Logo

    Duet3D

    • Register
    • Login
    • Search
    • Categories
    • Tags
    • Documentation
    • Order

    How to submit code changes for consideration

    Firmware developers
    3
    9
    750
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • MichaelM
      MichaelM last edited by

      Hello,

      I modified the PanelDue firmware to have a "WiFi Settings" dialog that allows the user to enter the SSID and password for their network. When they press Enter the specified SSID and Password is embeded in a M587 command. The intent is to make it easier for an end user to configure the WiFi settings of the DuetWiFi.

      I would like to submit these changes for consideration to be added to the root code.

      How do I go about doing this?

      Thanks,
      Mike

      1 Reply Last reply Reply Quote 0
      • gtj0
        gtj0 last edited by

        Your best bet is to submit a pull request at
        https://github.com/dc42/PanelDueFirmware

        1 Reply Last reply Reply Quote 0
        • MichaelM
          MichaelM last edited by

          The Pull request button is disabled. I suspect since I do not have write access? Or maybe I need to make a branch first?

          1 Reply Last reply Reply Quote 0
          • MichaelM
            MichaelM last edited by

            I made progress. Should I create a fork and upload to the fork?

            1 Reply Last reply Reply Quote 0
            • MichaelM
              MichaelM last edited by

              I think I submitted a pull request. It would be from MichaelM4.

              1 Reply Last reply Reply Quote 0
              • dc42
                dc42 administrators last edited by dc42

                Thanks, I'll take a look at it when I start work on the next major PanelDueFirmware release.

                Duet WiFi hardware designer and firmware engineer
                Please do not ask me for Duet support via PM or email, use the forum
                http://www.escher3d.com, https://miscsolutions.wordpress.com

                1 Reply Last reply Reply Quote 0
                • MichaelM
                  MichaelM last edited by

                  Hello,

                  Did you find and look over the code changes I submitted?

                  Thanks,
                  Mike

                  1 Reply Last reply Reply Quote 0
                  • dc42
                    dc42 administrators last edited by

                    I'm sorry, I can't see your pull request at https://github.com/dc42/PanelDueFirmware/pulls.

                    Duet WiFi hardware designer and firmware engineer
                    Please do not ask me for Duet support via PM or email, use the forum
                    http://www.escher3d.com, https://miscsolutions.wordpress.com

                    1 Reply Last reply Reply Quote 0
                    • MichaelM
                      MichaelM last edited by

                      I must have done it wrong. You can see the code here

                      https://github.com/MichaelM4/PanelDueFirmware

                      1 Reply Last reply Reply Quote 0
                      • First post
                        Last post
                      Unless otherwise noted, all forum content is licensed under CC-BY-SA