M500 not saving correctly in SBC mode. 3.2.2 Duet3

Th0mpy

Ok, closer inspection there is something weird.

A couple of the parameters for M665 don't seem to be saved properly during an M500.

Config-override.g

; Delta parameters
M665 L291.060:291.060:291.060 R137.213 H281.548 B120.0 X-0.090 Y0.326 Z0.000
M666 X-1.052 Y-0.498 Z1.550 A-0.00 B0.01

Before reboot:

3/27/2021, 7:49:19 AM	Connection interrupted, attempting to reconnect...
DCS has been stopped
3/27/2021, 7:49:19 AM	M999
3/27/2021, 7:49:14 AM	M666
Endstop adjustments X-1.05 Y-0.50 Z1.55, tilt X-0.27% Y1.42%
3/27/2021, 7:48:53 AM	M500

After reboot:

3/27/2021, 7:49:41 AM	M666
Endstop adjustments X-1.05 Y-0.50 Z1.55, tilt X0.00% Y0.01%
3/27/2021, 7:49:22 AM	Connection established

So it seems that M501 is working, it pulls the proper tilt, but the M500 does not save the updated tilt.

I'm going to recalibrate and run M500, I'll post the config-override.g

Th0mpy

Ok, here we are.

3/27/2021, 8:05:10 AM	M666
Endstop adjustments X-1.14 Y-0.45 Z1.59, tilt X-0.20% Y1.46%
3/27/2021, 8:05:04 AM	M500

; Delta parameters
M665 L291.060:291.060:291.060 R137.231 H281.551 B120.0 X-0.161 Y0.210 Z0.000
M666 X-1.135 Y-0.455 Z1.590 A-0.00 B0.01

The config-override.g isn't being updated with the tilt on an M500. I can confirm that manually editing the value does work.

droftarts

@Th0mpy thanks for your report and testing, one for @dc42 to fix!

Ian

Phaedrux

In meantime may want to upload the 3.2.2 zip file just for the bug fixes

https://github.com/Duet3D/RepRapFirmware/releases/download/3.2.2/Duet2and3Firmware-3.2.2.zip

dc42

@droftarts said in Weird error on my Delta:

@Th0mpy thanks for your report and testing, one for @dc42 to fix!

Ian

I've just re-tested M500 and M501. They are saving and loading the M566 tilt parameters for me. I don't recall making any changes in this area for more than a year.

Did you definitely run M500?

Th0mpy

@dc42 said in Weird error on my Delta:

d loading the M566 tilt parameters for me. I don't recall making any changes in this area for more than a year.
Did you definitely run M500?

Absolutely positive. I just ran a quick test where I calibrated, checked, saved, reloaded, and checked again. I also just updated to 3.2.2 just to make sure.

Th0mpy

@dc42 Is there something I can to to help qualify this more?

dc42

If you use M666 to adjust the tilt and one of the endstop adjustments, confirm that you have made the adjustment by sending M666 without parameters, and then send M500, do the new values get saved to config-override.g?

Th0mpy

@dc42 Ok, I tried it, it does save it but there seems to be a formatting issue on the A and B params:

; Delta parameters
M665 L291.060:291.060:291.060 R137.239 H281.544 B120.0 X-0.138 Y0.266 Z0.000
M666 X-1.000 Y-1.000 Z-1.000 A0.10 B0.10
; Heater model parameters
M307 H0 R0.630 C141.300:141.300 D4.00 S0.75 V14.0 B0
M307 H1 R2.227 C104.400:104.400 D6.00 S0.75 V14.0 B0

Am I going crazy here?

Phaedrux

Could it be a line length limit?

Th0mpy

@phaedrux My other printer's M666 line is much longer.

dc42

@th0mpy said in Weird error on my Delta:

@dc42 Ok, I tried it, it does save it but there seems to be a formatting issue on the A and B params:
; Delta parameters
M665 L291.060:291.060:291.060 R137.239 H281.544 B120.0 X-0.138 Y0.266 Z0.000
M666 X-1.000 Y-1.000 Z-1.000 A0.10 B0.10
; Heater model parameters
M307 H0 R0.630 C141.300:141.300 D4.00 S0.75 V14.0 B0
M307 H1 R2.227 C104.400:104.400 D6.00 S0.75 V14.0 B0
Am I going crazy here?

Odd, I did the same and it worked correctly. Are you definitely running firmware 3.2.2 ? Send M115 to check.

droftarts

@th0mpy Are you using an Single Board Computer with your Duet 3? Your M115 doesn't report this. I just tested the following, which seems to be stored and retrieved correctly:

The resultant M501 looks like this (in part):

; Delta parameters
M665 L161.612:161.612:161.612 R81.896 H173.484 B75.0 X-0.843 Y-0.003 Z0.000
M666 X-1.000 Y-1.000 Z-1.000 A10.00 B10.00
; Heater model parameters
M307 H1 R2.429 C140.000:140.000 D5.50 S1.00 V0.0 B0 I0

Though this is on a Duet 2 Maestro running 3.3beta2 (2021-03-10).

Ian

Th0mpy

Here's the result of M115:

FIRMWARE_NAME: RepRapFirmware for Duet 3 MB6HC FIRMWARE_VERSION: 3.2.2 ELECTRONICS: Duet 3 MB6HC v1.01 or later FIRMWARE_DATE: 2021-02-11

I am running in SBC mode.

Phaedrux

It would appear that DSF in SBC mode isn't saving the config-override.g correctly. One for @chrishamm ?

chrishamm

@phaedrux Yes, that's right, the tilt factors must be multiplied by 100 before they're written to config-override.g. I'll fix that in the next version.

Th0mpy

@chrishamm Will that fix it from not saving at all with M500 after calibration?

Th0mpy

@chrishamm do you know when you might have a version to test? I'd be happy to give it a whirl.

Th0mpy

@chrishamm and @dc42 Hey guys, just checking in. Did these updates make it into 3.3.0-b3? I just saw that was released but didn't see anything in the release notes. Can you let me know when I can give it a test?

chrishamm

@th0mpy Those changes are part of the 3.3-b3 pre-release. Feel free to test it again.