3.2.5-betta 1 small issues

stuartofmt

Hi @gtj0 -- again, great work, I use Dueui almost daily.

I'm seeing some small issues the latest release. I removed all prior versions files and did a clean install.
I'm running dueui under nginx on a windows against a Duet2 wifi. Note that dueui and all its sub-dir are in the dueui folder under the nginx "root".

Clearing browser (Chrome) of all cached objects prior to re-opening

Opening with:

http://localhost:8080/dueui/dueui.html?dueui_config_url=http://localhost:8080/dueui/dueui_config_default.json&theme=Darkly&duet_host=192.168.86.235&duet_polling_enabled=1

gives a UI with some labels garbled.

Editing the default config file with the equivalent settings to the above:

/*
 * You now have the capability to specify DueUI settings
...<snip> ...
 * for more info. 
*/

configFileSettings = {
	duet_debug_polling_enabled: 0,
	duet_host: "192.168.86.235",
	duet_password: "reprap",
	duet_poll_interval_1: 500,
	duet_debug_polling_enabled: 0,
	dueui_settings_dont_send_gcode: 0,
	dueui_test_mode: 0,
	duet_polling_enabled: 1,
	theme_name: "Darkly"
};

Clearing the browser cash and then attempting to open using

http://localhost:8080/dueui/dueui.html?dueui_config_url=http://localhost:8080/dueui/dueui_config_default.json

Edit: ~~yields the same result.~~
Seems I spoke too soon (may not have cleared cache properly).
When restarting using the above url and config file settings - I end up at the setup screen

gtj0

@stuartofmt Let me re-test before I release beta2. I actually run it like you do.

gtj0

@stuartofmt In the second case, dueui_config_default.json has the configFileSettings object commented out. Since duet_host isn't specified in the query parameters, and it doesn't exist in the browser's storage, we've got no clue how to connect. That's why the settings screen came up. There should have been a warning popub before that saying that DueUI couldn't connect. That message could probably be a little better worded.

stuartofmt

@gtj0 said in 3.2.5-betta 1 small issues:

In the second case, dueui_config_default.json has the configFileSettings object commented out.

Not sure I understand. Take a look a the portion of the config file I posted above. I believe I have commented out correctly i.e. the configFileSettings block is not surrounded by /* ...*/.

Edit:
P.S. With the configFileSettings block uncommented. The browser opens directly into the settings page without any warnings.
Same thing happens on beta 2

gtj0

@stuartofmt Ok, my fault. I saw "dueui_config_default.json" and assumed you were using it without modifying it.

So, yeah I can reproduce the issue. It has to do with the order in which the settings are applied and the automatic saving of settings on the Settings panel. I might have to get rid of the automatic save and have 2 save buttons, one to save for the tab session, and another to save to the browser.

stuartofmt

@gtj0 said in 3.2.5-betta 1 small issues:

I might have to get rid of the automatic save and have 2 save buttons,

Is there a natural order that can be used to inform the logic? For example:
Is there a query string that ONLY specifies a config file ? If so parse the config file.
Is there a query string with enough elements specified to start ? If so start
Else (no query string or 1 or 2 failed) --> look to see if the configuration is saved at the session / tab level(s)
Otherwise: Go to setup page.

gtj0

@stuartofmt Yeah that's kind of the logic I use but there's a chicken and egg thing going on because you have to find a config file before you can get the settings out of it but you have to have some settings already to know where to look.

I think I have it working now but I'm going to wait until tomorrow and test it again before doing a beta3.