Probe center of hole?

[wilriker]

@dc42 I checked his implementation against mine and the only difference is that mine uses existing helper functions to simplify code and adds some errors for missing parameters. Since we implemented it for the same reason and my implementation is currently used I would say use mine.

EDIT: Here's the Pull Request.

[deckingman]

More divergence between the needs of CNC users and FDM users.......

[wilriker]

@deckingman Now you're on the hunt...

[gtj0]

@dc42 said in Probe center of hole?:

M-codes 673, 674 and 675 are not implemented in standard RepRapFirmware. I don't know who added them to the GCodes wiki page.

@rzi Oops, sorry about that. I didn't notice they weren't implemented.

[dc42]

@wilriker said in Probe center of hole?:

@dc42 I checked his implementation against mine and the only difference is that mine uses existing helper functions to simplify code and adds some errors for missing parameters. Since we implemented it for the same reason and my implementation is currently used I would say use mine.

EDIT: Here's the Pull Request.

Thanks. Can you do a separate PR for RRF 3 to support using a Z probe as an alternative to an endstop switch, using the same mechanism as M585 in RRF3? See https://duet3d.dozuki.com/Wiki/RepRapFirmware_3_overview#Section_M585.

[wilriker]

@dc42 said in Probe center of hole?:

Can you do a separate PR for RRF 3 to support using a Z probe as an alternative to an endstop switch, using the same mechanism as M585 in RRF3?

I'll probably provide this either today or early next week.

[wilriker]

@dc42 There you go: Pull Request for RRF 3.

[wilriker]

@dc42 I totally forgot: an implementation for M673 can also be found in v2-chrishamm branch in your repo. But since I don't know what it all comprises besides the code in GCode2.cpp I can't tell you what to take over. Also it seems he started implementing M674 but it's not finished.

[rzi]

@gtj0 said in Probe center of hole?:

@dc42 said in Probe center of hole?:

M-codes 673, 674 and 675 are not implemented in standard RepRapFirmware. I don't know who added them to the GCodes wiki page.

@rzi Oops, sorry about that. I didn't notice they weren't implemented.

No problem. An implementation seem not too far away it seems, if I interpret the other posts right. Good thing!

[wilriker]

@rzi said in Probe center of hole?:

No problem. An implementation seem not too far away it seems, if I interpret the other posts right. Good thing!

My pull requests have been accepted today so it will be in 2.03RC4 and also in the next 3.0 build.

[dc42]

2.03RC4 is now released. Thanks @wilriker for the PR.

[rzi]

@dc42 said in Probe center of hole?:

2.03RC4 is now released. Thanks @wilriker for the PR.

Damn, you guys are fast as lightning! Thanx