Could use some feedback on a DSF packaging pull request
If anyone's hacking on the DSF, I could use some feedback on a pull request that refactors the packaging stuff.
I'm guessing @chrishamm is pretty busy at the moment and might not get to it for a while.
@gtj0 apologies for not sorting out a category until now, hence moving the post into here.
I hope @chrishamm will have a chance to look at it soon. I don't have any specific comments, other than its large amount of additions/changes in one pull request which makes it more difficult to merge.
This is looking great - I will check it out and merge it very soon. You could remove the dpkg-scanpackages part though, because that part has already been automated on the server side.
@T3P3Tony No worries!
@chrishamm Cool, I'll remove the scanpkgs then I'll do a separate commit/pull request for the rpm support.
@wilriker When you build for Arch, how are you treating the dwc "2.0.0-2" version string since the dash makes it an illegal 'Version"?
wilriker last edited by wilriker
@gtj0 Yeah, that's a special case where I rewrite the version completely to what the actual DWC version is. In the current
unstablepackage (not published in AUR) has
EDIT: also the
-2means second repack/release of version
2.0.0so this is not really part of the version. At least for Arch Linux
PKGBUILDfiles this will be controlled by a separate variable
Gotcha, thanks! Yeah that's what I did with the -2. I made it part of the Release rather than Version.