Could use some feedback on a DSF packaging pull request

gtj0

If anyone's hacking on the DSF, I could use some feedback on a pull request that refactors the packaging stuff.

https://github.com/chrishamm/DuetSoftwareFramework/pull/62

I'm guessing @chrishamm is pretty busy at the moment and might not get to it for a while.

gtjoseph opened this pull request in chrishamm/DuetSoftwareFramework

closed Refactor packaging scripts #62

T3P3Tony

@gtj0 apologies for not sorting out a category until now, hence moving the post into here.

I hope @chrishamm will have a chance to look at it soon. I don't have any specific comments, other than its large amount of additions/changes in one pull request which makes it more difficult to merge.

chrishamm

This is looking great - I will check it out and merge it very soon. You could remove the dpkg-scanpackages part though, because that part has already been automated on the server side.

gtj0

@T3P3Tony No worries!

@chrishamm Cool, I'll remove the scanpkgs then I'll do a separate commit/pull request for the rpm support.

gtj0

@wilriker When you build for Arch, how are you treating the dwc "2.0.0-2" version string since the dash makes it an illegal 'Version"?

wilriker

@gtj0 Yeah, that's a special case where I rewrite the version completely to what the actual DWC version is. In the current stable package that's 2.0.0.RC8.b3. The unstable package (not published in AUR) has b4.

EDIT: also the -2 means second repack/release of version 2.0.0so this is not really part of the version. At least for Arch Linux PKGBUILD files this will be controlled by a separate variable pkgrel.

gtj0

Gotcha, thanks! Yeah that's what I did with the -2. I made it part of the Release rather than Version.