Duet3D Logo Duet3D
    • Tags
    • Documentation
    • Order
    • Register
    • Login

    Why does RRF3Common live in CANlib?

    Scheduled Pinned Locked Moved
    Firmware developers
    2
    2
    162
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • oliofundefined
      oliof
      last edited by

      Hi,
      spelunking through code I found RRF3Common.[h|cpp] living in CANlib. It starts with the following comment:

      /*
       * RRF3Common.h
       *
       *  Created on: 17 Oct 2021
       *      Author: David
       *
       *  This file contains definitions common to all implementations of RRF3 on Duets, including those that don't support CAN
       */
      

      Purely out of curiosity, why do these files reside with CANlib and not some other place like RRFLibraries?

      <>RatRig V-Minion Fly Super5Pro RRF<> V-Core 3.1 IDEX k*****r <> RatRig V-Minion SKR 2 Marlin<>

      dc42undefined 1 Reply Last reply Reply Quote 0
      • dc42undefined
        dc42 administrators @oliof
        last edited by

        @oliof RRFLibraries is a true library project, used not only by RRF but now also by PanelDueFirmware. Whereas CANlib is used only by RRF and Duet3Expansion. So CANlib was a more obvious location to define constants that for Duet 3 need to be visible to Duet 3 expansion board firmware as well as to the RRF project.

        Duet WiFi hardware designer and firmware engineer
        Please do not ask me for Duet support via PM or email, use the forum
        http://www.escher3d.com, https://miscsolutions.wordpress.com

        1 Reply Last reply Reply Quote 1
        • First post
          Last post
        Unless otherwise noted, all forum content is licensed under CC-BY-SA