Duet3D Logo Duet3D
    • Tags
    • Documentation
    • Order
    • Register
    • Login

    3.5: Linux build of CrcAppender isn't marked executable

    Scheduled Pinned Locked Moved
    Firmware developers
    3
    8
    374
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • gtj0undefined
      gtj0
      last edited by

      ...so the final build step fails. Github issue and PR forthcoming.

      droftartsundefined 1 Reply Last reply Reply Quote 0
      • droftartsundefined
        droftarts administrators @gtj0
        last edited by

        @gtj0 So set it as an executable? It says to do that in the MacOS instructions, step 3 https://github.com/Duet3D/RepRapFirmware/wiki/Building-RepRapFirmware#instructions-for-building-under-macos

        Ian

        Bed-slinger - Mini5+ WiFi/1LC | RRP Fisher v1 - D2 WiFi | Polargraph - D2 WiFi | TronXY X5S - 6HC/Roto | CNC router - 6HC | Tractus3D T1250 - D2 Eth

        gtj0undefined 1 Reply Last reply Reply Quote 0
        • gtj0undefined
          gtj0 @droftarts
          last edited by

          @droftarts said in 3.5: Linux build of CrcAppender isn't marked executable:

          @gtj0 So set it as an executable? It says to do that in the MacOS instructions, step 3 https://github.com/Duet3D/RepRapFirmware/wiki/Building-RepRapFirmware#instructions-for-building-under-macos

          Ian

          Well, it was executable in 3.4 and setting it to executable makes a change in the git index so the tree is marked dirty.

          1 Reply Last reply Reply Quote 0
          • gtj0undefined
            gtj0
            last edited by

            Actually, while we're talking about it, how about also changing CrcAppender in the post-build step that appends the crc to...

            `"${workspace_loc:/${ProjName}/Tools/CrcAppender/${OsType}-x86_64/CrcAppender}"

            On Linux, ${OsType} resolves to linux.
            On Windows, it resolves to win32 (even on 64 bit).
            Not sure about macos but it wold be easy enough to find out. Probably macos or osx.

            It would require renaming the directories under Tools/CrcAppender but it would remove the need for users to copy the appropriate binary to a directory outside the project that's already in their PATH.

            droftartsundefined dc42undefined 2 Replies Last reply Reply Quote 0
            • droftartsundefined
              droftarts administrators @gtj0
              last edited by

              @gtj0 That would be good. @dc42 ?

              Ian

              Bed-slinger - Mini5+ WiFi/1LC | RRP Fisher v1 - D2 WiFi | Polargraph - D2 WiFi | TronXY X5S - 6HC/Roto | CNC router - 6HC | Tractus3D T1250 - D2 Eth

              1 Reply Last reply Reply Quote 0
              • dc42undefined
                dc42 administrators @gtj0
                last edited by

                @gtj0 good idea! What does OsType resolve to on a Mac?

                Duet WiFi hardware designer and firmware engineer
                Please do not ask me for Duet support via PM or email, use the forum
                http://www.escher3d.com, https://miscsolutions.wordpress.com

                gtj0undefined 1 Reply Last reply Reply Quote 0
                • gtj0undefined
                  gtj0 @dc42
                  last edited by

                  @dc42 said in 3.5: Linux build of CrcAppender isn't marked executable:

                  @gtj0 good idea! What does OsType resolve to on a Mac?

                  According to org.eclipse.core.runtime.Platform, OsType is one of...

                  public static final String OS_WIN32 = "win32";
                  public static final String OS_LINUX = "linux";
                  public static final String OS_MACOSX = "macosx";
                  

                  There are others for aix, solaris, hpux, etc but I don't think we care about them 🙂

                  gtj0undefined 1 Reply Last reply Reply Quote 0
                  • gtj0undefined
                    gtj0 @gtj0
                    last edited by

                    @dc42 Are you going to do this or should I submit a pull request for it?

                    1 Reply Last reply Reply Quote 0
                    • First post
                      Last post
                    Unless otherwise noted, all forum content is licensed under CC-BY-SA