Confused about recent 12864 Display Fix (3.5.0 rc 2)
-
I have a duet 5 Mini with a SBC and a 12864 Display.
Since SD card access doesn't work with a SBC i made a button for every Macro:button R26 C40 F0 W64 V0 T"Lights OFF" A"M98 P#0" L"/macros/LightOFF"This worked flawlessly until some Time last year (can't say exactly which update broke it. I assumed it would be fixed someday so i just ignored it.
Now i updated to 3.5.0 Release Candidate 3 and saw that in rc2 there was a fix that should solve my issue:"In menu files for a 12864 display it was not possible to include a double-quote character in the command string for an A parameter (issue 909). This made it impossible to use the M98 command in such a parameter because the P argument of the M98 command must now be enclosed in double quotes."
https://github.com/Duet3D/RepRapFirmware/issues/909
Sadly, I'm confused how i have to change my code to get it to work. I tried a few things, but none of them worked.
It would be great if someone could modify my code for me.
-
@Yukikaze You are missing double-quotes in your M98 command. Does this work?
button R26 C40 F0 W64 V0 T"Lights OFF" A"M98 P""#0""" L"/macros/LightOFF" -
@chrishamm No, i tried that already.
-
@Yukikaze What about
button R26 C40 F0 W64 V0 T"Lights OFF" A"M98 P""/macros/LightOFF""" -
@chrishamm Yes, that worked. Thanks a lot.
-
@Yukikaze interesting, last time I looked at the code it appeared that the #0 parameter in the M98 command should get double quotes surrounding it automatically. I'll take another look.
-
@Yukikaze I confirm that this was not working in rc3. I have corrected the 3.5 source code and tested the fix. Thank you for reporting it.
