M291 messages are not always displayed in macros

mfs12

Hey @aitor, also could reproduce the screensaver bug.

Thanks for reporting both issues. I created to issues:

M291 S0 and S1 issue https://github.com/Duet3D/PanelDueFirmware/issues/146
M291 S3 and S4 screensaver issue https://github.com/Duet3D/PanelDueFirmware/issues/147

Any update concerning this problems will be reflected in the gitlab issues.

mfs12 created this issue in Duet3D/PanelDueFirmware

closed M291 S0 and S1 are not displayed when M292 follows #146

mfs12 created this issue in Duet3D/PanelDueFirmware

closed M291 leads to unresponsiveness when screensaver is activated #147

mfs12

Hey @Aitor, i think i found the issues. I build a test release. Would be cool if you could test them and provide feedback. If positive I am going to build another release candidate.

Check the attached image file.

PanelDueFirmware-3.3.0-rc2-m291-5.0i-7.0i-nologo.bin

mfs12

@Aitor weird enough... so far this fixes only the screensaver bug. The other one persists. When i was testing it it appeared ok, but i was wrong!

Aitor

Good morning @mfs12

Running the macros from PanelDue:

M291 S0 and S1 messages are not shown, this is fine according to what we have discussed.
M291 messages S2 and S3 are displayed normally.

Running macros from ControlWeb without the guard:

M291 S0 and S1 messages are displayed but very late, I had to switch from G4 S5 to G4 S10 to get the messages displayed

M291 messages S2 and S3, displayed normally.

Running the macros from ControlWeb with Screensaver active:

The Screensaver is not blocked, so it works correctly, the message is not hidden and Screensaver is not deactivated, it behaves like "Running macros from ControlWeb without the screensaver" but with the Screensaver active at all times, I do not dislike this behaviour,but this is my opinion.

The Screensaver bug is fixed, I will do more tests if I find something and let you know.

I'll be happy to do more tests, let me know with anything, I'll be happy to help in any way I can.

By the way, if something is not well understood tell me, it may be a bad translation.

Best regards and thanks

Aitor

Good morning @mfs12

I hadn't read your last message, as far as I've been able to check it's a timing thing, since version 3.2.9 which is the first one I tried since "3.1", I've noticed that the messages are a bit slower.

As I don't know about programming I can't know why.

Best regards

mfs12

@Aitor thanks for testing.

I had deeper look into M291 S0 and S1 issue and this seems to be more complex. So let's see how long i twill take to fix that. The only workaround so far is to avoid M292 gcodes in scripts.

dc42

M292 codes should not be used in scripts, except in exceptional circumstances such as emergencies, where you might want to dismiss a dialogue that hasn't been acknowledged so that you can display a new message.

chrishamm

@dc42 @mfs12 I will take a look at this next week, IMO M292 should be able to dismiss non-blocking messages from macro files, especially because that's already supported by DWC.

flobler

I am seeing similar issues, which I described here: https://forum.duet3d.com/topic/22667/m291-messages-ignored-by-paneldue/17?_=1626901114508

mfs12

@Aitor this issue should be solved with release paneldue-3.4.0-pre1.

I mark this issue as solved now. If you are still experiencing problems as described here either re-open this thread or start a new thread.

https://forum.duet3d.com/topic/24889/paneldue-3-4-0-pre1-released/6