Duet3D Logo Duet3D
    • Tags
    • Documentation
    • Order
    • Register
    • Login

    Height Map Padding

    Scheduled Pinned Locked Moved
    Duet Web Control
    5
    34
    1.7k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • CCS86undefined
      CCS86
      last edited by

      By changing this character to a 0, it collapses the text. This seems to show that the text is just trying to fill an over-sized pane:

      e0d835ed-4b54-40fc-aaed-8951a0a4a53c-image.png

      1 Reply Last reply Reply Quote 0
      • CCS86undefined
        CCS86
        last edited by CCS86

        Okay, I think I figured out what is going on:

        • The statistics pane wants to scale vertically to match the height of the tallest pane
        • The middle heightmap pane is set to a fixed aspect ratio, so when the window is in a very wide aspect ratio, the middle pane gets very tall and forces the statistics pane too tall
        • The left pane which lists your saved height maps also auto scales height taller when the list gets long, so it can also force the statistics pane to be too tall

        Screen recording that shows the issue dynamically:
        2022-08-04-11-07-59.mp4

        I'm not sure what the cleanest solution is here. Maybe DWC could lookup the current monitor aspect ratio to decide which aspect ratio the height map pane should be.

        It would also be nice if the height map list pane was scrollable itself, instead of autosizing and forcing the other panes to be too tall to fit.

        Norderundefined 1 Reply Last reply Reply Quote 0
        • Norderundefined
          Norder @CCS86
          last edited by

          @ccs86
          if so then it's a case for @chrishamm who programmed the DWC, if I'm not mistaken.

          DDA5X... 0.9° Stepper... Linearrails... Duet 2 Wifi... PT100 Board... Duet IR-Probe... Dyze Pro Kit up to 500°C.. etc
          Thingiverse

          jay_s_ukundefined 1 Reply Last reply Reply Quote 0
          • jay_s_ukundefined
            jay_s_uk @Norder
            last edited by

            @norder it's an issue for @Sindarius as I mentioned previously as he programmed the height map plugin

            Owns various duet boards and is the main wiki maintainer for the Teamgloomy LPC/STM32 port of RRF. Assume I'm running whatever the latest beta/stable build is

            Sindariusundefined 1 Reply Last reply Reply Quote 2
            • Sindariusundefined
              Sindarius @jay_s_uk
              last edited by

              @jay_s_uk I rewrote the 3D component of the heightmap plugin which replaced ThreeJS to BabylonJS which is used for the G-Code Viewer. It does come down to adjusting how the controls layout and resize in code.

              CCS86undefined 1 Reply Last reply Reply Quote 3
              • CCS86undefined
                CCS86 @Sindarius
                last edited by

                @sindarius said in Height Map Padding:

                @jay_s_uk I rewrote the 3D component of the heightmap plugin which replaced ThreeJS to BabylonJS which is used for the G-Code Viewer. It does come down to adjusting how the controls layout and resize in code.

                Is that something you are able to change, or is it in the DWC code?

                Sindariusundefined 1 Reply Last reply Reply Quote 0
                • Sindariusundefined
                  Sindarius @CCS86
                  last edited by

                  @ccs86 It has to be changed in the plugin which is bundled with DWC.

                  CCS86undefined 1 Reply Last reply Reply Quote 1
                  • CCS86undefined
                    CCS86 @Sindarius
                    last edited by

                    @sindarius said in Height Map Padding:

                    @ccs86 It has to be changed in the plugin which is bundled with DWC.

                    Is it something user editable, like a config file?

                    If not, would you be willing to push an update?

                    Sindariusundefined 1 Reply Last reply Reply Quote 0
                    • Sindariusundefined
                      Sindarius @CCS86
                      last edited by

                      @ccs86 Not user editable unless you download DWC and make the modifications yourself and make your own build of DWC. It's something I can look at but it won't be today.

                      CCS86undefined 1 Reply Last reply Reply Quote 1
                      • CCS86undefined
                        CCS86 @Sindarius
                        last edited by

                        @sindarius said in Height Map Padding:

                        @ccs86 Not user editable unless you download DWC and make the modifications yourself and make your own build of DWC. It's something I can look at but it won't be today.

                        Just checking to see if the change made it into the new DWC release.

                        Sindariusundefined 1 Reply Last reply Reply Quote 0
                        • Sindariusundefined
                          Sindarius @CCS86
                          last edited by

                          @ccs86 I have not had time to make any changes to the heightmap at this point.

                          CCS86undefined 2 Replies Last reply Reply Quote 0
                          • CCS86undefined
                            CCS86 @Sindarius
                            last edited by

                            @sindarius said in Height Map Padding:

                            @ccs86 I have not had time to make any changes to the heightmap at this point.

                            Just checking in.

                            1 Reply Last reply Reply Quote 0
                            • CCS86undefined
                              CCS86 @Sindarius
                              last edited by

                              @Sindarius said in Height Map Padding:

                              @ccs86 I have not had time to make any changes to the heightmap at this point.

                              Do you think you might have time for this soon?

                              Sindariusundefined 1 Reply Last reply Reply Quote 0
                              • Sindariusundefined
                                Sindarius @CCS86
                                last edited by

                                @CCS86 I made some changes to the control that will likely be in 3.5

                                CCS86undefined 2 Replies Last reply Reply Quote 1
                                • CCS86undefined
                                  CCS86 @Sindarius
                                  last edited by

                                  @Sindarius said in Height Map Padding:

                                  @CCS86 I made some changes to the control that will likely be in 3.5

                                  Thank you!

                                  1 Reply Last reply Reply Quote 0
                                  • CCS86undefined
                                    CCS86 @Sindarius
                                    last edited by

                                    @Sindarius said in Height Map Padding:

                                    @CCS86 I made some changes to the control that will likely be in 3.5

                                    Did this change make it into 3.5 beta 1?

                                    Sindariusundefined 1 Reply Last reply Reply Quote 1
                                    • Sindariusundefined
                                      Sindarius @CCS86
                                      last edited by

                                      @CCS86 e23b9a7e-baa4-4f3c-a4d1-42df5972d9ed-image.png

                                      CCS86undefined 1 Reply Last reply Reply Quote 1
                                      • CCS86undefined
                                        CCS86 @Sindarius
                                        last edited by

                                        @Sindarius said in Height Map Padding:

                                        @CCS86 e23b9a7e-baa4-4f3c-a4d1-42df5972d9ed-image.png

                                        Looks great, thanks!

                                        1 Reply Last reply Reply Quote 0
                                        • First post
                                          Last post
                                        Unless otherwise noted, all forum content is licensed under CC-BY-SA