Integrate polish translation

mfs12

Hey @Chri55, for detailed build instructions and build setup please check

https://github.com/Duet3D/PanelDueFirmware/blob/master/BuildInstructions.md

What translation did you do? I am interested in it, as I plan to fix a few translations for the next release. Are you on github? You can then always send a pull request.

Chri55

@mfs12 I made a Polish translation, i don't have an account on github but i can make one and send files there if it is a better solution

mfs12

Yes, polish nice. This needs definitely some testing because they have a couple of special characters. And i am not sure if they are all supported.

You can also post the file here as an attachment.

mfs12

i will have a look at it next week. Thanks.

mfs12

Any further progress on polish translation will be represented in https://github.com/Duet3D/PanelDueFirmware/issues/171

mfs12 created this issue in Duet3D/PanelDueFirmware

closed integrate polish translation #171

Chri55

@mfs12 I made a pull request, but if you made a section for it you can delete the one i mede it has number #170 (i thing i post it in a wrong place anyway). Yes, there are characters like ą,ę and some others that might cause some problems.
I sending a .hpp file with a polish incuded
Strings.hpp

mfs12

Hey @Chri55 , what paneldue device do you have? I would like to send you a build so you can test the translation.

Also I realized it's not 100% complete. Please check the attached file for missing translations and errors.

polish-translation-0.1.txt

Chri55

@mfs12 I will upload it to i5 and i7 paneldue. Ok thanks I will check that

Chri55

@chri55 Can you send it in other file or give me a hint how to download that file because it opens in the browser and all words with polish letters have something wired done to them and it is impossible to check if there are any errors. I see few mistake that I put translations one line lower that correct word. I will correct it while i will be abe to download the file and check not translated words maybe i missed some of them.

mfs12

Hey @Chri55,

i reformatted the translation file to use windows fileendings. I hope this was the issue.

And find further attached the test firmware for you PD-7.0i.

Chri55

@mfs12 I checked and it works fine (on 5.0i panel, unfortunately 7.0 is unavailable at the moment, I think it will be ok if it works well on 5.0).
I corrected a few mistakes and too long words. I also left some words in English, they make more sense for people who use printers than polish translations.
polish translation.txt

Chri55

@chri55 If it will not be a big problem could you compile a polish to older version because on a printer with electronics in V2 version it doesn't work.
Below is the translation for 1.24 paneldue release.
polish for electronics v2.txt

mfs12

Hey @Chri55, i sent you just a version for PD 7.0i. When this will be released more hardware will be supported. This is just a test build.

Chri55

@mfs12 ok, thanks for information

mfs12

@Chri55 thanks for your translations, with my very little polish i tried to integrate things as good as possible. While reviewing i found those translations either misaligned or missing. It would be very helpful if you can help me out here.

orig->screensaverAfter: 'Screensaver ', 'Wygaszacz '
orig->touchTheSpot: 'Touch the spot', 'Touch the spot'
orig->statusValues[j]: 'Idle', 'Idle'
orig->statusValues[j]: 'Off', 'Standby'
orig->statusValues[j]: 'Cancelling', 'Inicjowanie'

Here you can double check how things were integrated. If you find something, please leave comment. By clicking on left column you can comment directly on the code.

https://github.com/Duet3D/PanelDueFirmware/pull/175/files

mfs12 opened this pull request in Duet3D/PanelDueFirmware

closed Integrate polish translation #175

mfs12

@Chri55 i found another problem...

"Wygaszaj gdy bezczynny" is too long. it may have only half the length.

If you could provide the missing translations, see comment above then i can merge it. Otherwise probably won't make it into the next release.

mfs12

@Chri55 how are you doing? Are you available to finish polish translation?

Rafal_ll

Cześć Chri55
Możesz dokończyć tłumaczenie... Było by fajnie zobaczyć nasz język w menu
Jeśli mogę Ci jakoś pomóc to chętnie.
Pozdrawiam

Hi Chri55
You can finish the translation ... It would be nice to see our language on the menu
If I can help you somehow, I will be happy to.
greetings

Rafal_ll

Dokończyłem twój plik. Jeśli chcesz to sprawdź.
Proponuję go umieścić w następnej wersji firmware

I have finished your file. If you want to check it out.
I propose to include it in the next firmware version

polish-translation-0.3.txt

mfs12

@Rafal_ll thanks a lot for you help!!!

now only two strings are missing... if you make it on time, they get into the next release.

Status Values:
- 'Off', 'Off'
- 'Cancelling', 'Cancelling'