thanks! i'll have a look at it when i'm back from very short vacation!
you are right after writing my post i realized that these defines should go into a header instead.
there are only a few other mentions of RADDS in coreng. One is in AnalogIn.cpp line 94:
[[c]]
#if SAM3XA
#ifdef __RADDS__
if (ADC_TEMPERATURE_SENSOR != GetAdcChannel(channel))
#endif
adc_enable_channel(ADC, GetAdcChannel(channel));
if (GetAdcChannel(channel) == ADC_TEMPERATURE_SENSOR)
{
adc_enable_ts(ADC);
}
#endif
1st i disklike nested #ifdef whatever, this makes everything unreadable. 2nd yoda style (ADC_TEMPERATURE_SENSOR != GetAdcChannel(channel) is a no no.
however i'm asking myself if this is actually needed because in any case it would call adc_enable_ts if needed. in the RADDS case not calling adc_enable_channel
before then. so either there is a bug when doing this when using the radds board or it is not neccessary and can be forgotten.
if your time permits you might want to look into SharedSpi.cpp as well. in dcnewmans fork are a 2 more #ifdef's for the RADDS case in lines 186 and 386
[[c]]
#if defined(USE_SAM3X_DMAC) && !defined(__RADDS__)
you know better than me if these are necessary or not facing the current implementation. Afaics, these were the only changes to the actual source which depend
on anything radds related. if so coreng would be radds safe after your changes.
i looked at the radds schematics and think that using a small adapter pcb the esp could also be connected to spi and the sdcard rewired to the hsmci port. thus
enabling high speed uploads there as well (preventing however the use of an lcd but not serial panel or whatever).