crc32appender now needed for RRF?

gtj0

@wilriker I see you have a pull request open for it in Duet3Expansion but we also need it for RRF. Is this your own code or did it come from somewhere else?

wilriker

@gtj0 That's my own code. And there was some confusion on where to put the PR. At first I had it in the RRF repo, then realized it's only used in the expansion board firmware (at that time), so moved it over. Then @dc42 told me it will be used in RRF as well but I forgot to move it back.

JoergS5

@wilriker How about putting it into RRFLibraries, where support algorithms are gathered.

dc42

@JoergS5 said in crc32appender now needed for RRF?:

@wilriker How about putting it into RRFLibraries, where support algorithms are gathered.

RRFlibraries is just code for linking with other projects. RepRapFirmware already has a separate Tools folder.

smoki3

Is there a possibility to get it working on a mac?

wilriker

@smoki3 I will add one in a moment to the repo. Meanwhile use this one in my Dropbox.

smoki3

how to add it in eclipse?

gtj0

@smoki3 said in crc32appender now needed for RRF?:

how to add it in eclipse?

For now, you can copy it to any directory in your PATH. Eclipse will automatically pick it up.

smoki3

I copied it to the root folder of the RepRapFirmware directory. Does not work

gtj0

@wilriker Your commit to add it needs to add the appropriate Tools/crc32appender directories to the PATH in Eclipse or we'll have to manually copy it to a system directory.

gtj0

@smoki3 said in crc32appender now needed for RRF?:

I copied it to the root folder of the RepRapFirmware directory. Does not work

It has to be a directory in your $PATH.

smoki3

@gtj0

I get this:

/bin/sh: crc32appender: command not found

dont know where my $PATH is

wilriker

@smoki3 in the command line type

echo $PATH

it should give you a colon-separated list of directories where the system looks for executables by default.

wilriker

@gtj0 said in crc32appender now needed for RRF?:

@wilriker Your commit to add it needs to add the appropriate Tools/crc32appender directories to the PATH in Eclipse or we'll have to manually copy it to a system directory.

I just realized that this will be very complicated since the binaries all have the same name but need to be different for the different operating systems.

smoki3

@wilriker

echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Users/kevin/.android-sdk-macosx/platform-tools/:/Users/kevin/Library/platform-tools/

I added it to the /usr/local/bin

but it does not work in ecplise.

In the terminal it works

gtj0

@wilriker said in crc32appender now needed for RRF?:

@gtj0 said in crc32appender now needed for RRF?:

@wilriker Your commit to add it needs to add the appropriate Tools/crc32appender directories to the PATH in Eclipse or we'll have to manually copy it to a system directory.

I just realized that this will be very complicated since the binaries all have the same name but need to be different for the different operating systems.

You may be able to rename the directories to match some Eclipse or environment variable. I think there's a variable in Eclipse named "platform" or something close then you could add the path as ${workspace_dir}/Tools/crc32appender/${platcorm}

Not sure if those are the exact variable names.

dc42

I just put in the same /bin directory that I put miscellaneous binaries in, which is already on my PATH. This is under Windows 10 x64.

gtj0

@smoki3 I also put it in /usr/local/bin and it worked from Eclipse. Did you restart Eclipse? You shouldn't have to but it may help.

You can also try running "make" manually...
From the output directory (Duet2_RTOS, Duet3_V06, etc), run make clean and make and see if that works.

gtj0

@wilriker These look like they could be good variables to use:

HostOsName
OsType
target.os

smoki3

@gtj0

Its funny, in the terminal it is working with make... In eclipse not

I figured out that eclipse only uses:

/usr/bin:/bin:/usr/sbin:/sbin

But on the mac we dont have permissions to add files to these folders

Any why to add another path to $PATH?