@OwenD said in RRF bracket notation in mathematical equation - syntax question:

@Wurke
If you're doing your code in a text editor, make sure it uses Unix style line ends. LF only, not CRLF
Otherwise the line numbers reported in errors will be out.

This will be fixed in RRF 3.5beta2.

@Falcounet Fab. Thank you. There are no examples of this in the docs that I could see so wasn't sure how to implement it, brackets etc

@droftarts said in LED rainbow effects:

This would simplify the code, but would mean more memory is taken up with the three long array variables. Is that 'bad' programming?!

It's not "bad programming" to take advantage of available resources.
Why have X amount of memory allocated/available and only ever use X/3 ?
Unless it affects performance in some way , I say use whatever is available.

@OwenD, thank you, I will see if I can manage to cobble something together !

@OwenD That worked! I just had to swap the 1 and 0, true false since my switch is normally closed. THANKS!

@bitofadummy try again, I upvotes a few posts so that might help get it past the spam filters

@ender_swichwire

The simple solution is to always move the z axis up at the start of homing to clear the bed. Something like 5 or 10 mm.

The better solution would be to check the status of the probe and only move up if the probe is trigger. The could be accomplished through conditional statements.

@poohzaza Good idea to upgrade to the latest v3.4.5 then. There is also a DWC plugin RelaseMgr which highlights potential incompatibilites since your last firmware version.

@xerato said in Gcode to make LED Light flash on/off repeatedly:

If you manage to make, the code work properly? If yes, can you please share the code here?
I just got the same led strips, but I didn't know that it could be complicated to set them up properly. I thought they would have an application like a smart led light bulb, so I just set the time to choose the color. I'm thinking right now of buying other strips from the vont brand. My friend who has these strips told me they have a proper application, so we have no problem setting them up. So if you didn't make the code work let me know, and I will order new strips momentarily.

Have to "bite the bullet"a little bit here and admit defeat when it comes to calculating the offset for both probes.

And since i'm moving over to direct nozzle probing and ditching that second probe static to the bed i'm not inclined to try fixing it either 🤣

So i've opted to turn off the Z-pin offset calculation in the newest version of this script.
And with that i've also moved over to doing all Z homing with the klicky probe rather than on the Z-pin. This removes one "fudge" factor by only using the Z-pin to calculate the Klicky-probe offsett AND it makes transitioning to direct nozzle probing a little bit easier since down the road when it comes to homing macros etc.

Version 2.3 of the macro:

; /sys/lib/z_cal.g (v2.3) ; Called when "M98 P"/sys/lib/z_cal.g" is sent ; Used to calibrate the Z offsett between the Nozzle and buildplate. ; - - ; ====================--------------------------------------------------------- ; - - ; IMPORTANT!! Do you wish to calibrate K1 / Z-pin as well? (Not working like intended as of v2.3 so I would advice to not use it!) var calibrate_Z_Pin = false ; - - ; ====================--------------------------------------------------------- ; - - ; ====================--------------------------------------------------------- ; Preparation before probing ; ==================== ; Report whats going on M291 R"Z Offset Calibration" P"Please wait..." T0 ; Leveling bed message ; The distance from the body of the klicky probe to it's own trigger point var base_Hot_offset = global.klicky_offset var add_Cold_offset = 0.06 ; Remember the old offsets var old_k0_offset = sensors.probes[0].triggerHeight ; Old klicky offset var old_k1_offset = sensors.probes[1].triggerHeight ; Old z-pin offset ; Reset existing calibration G31 K0 Z7.50 ; Reset klicky G31 K1 Z0.00 ; Reset z-pin ; Variables for klicky calculation var temp0 = 0 ; Placeholder value var temp1 = 5 ; Placeholder value var temp2 = 10 ; Set value above target value ; Variables for z-pin calculation var temp3 = 0 ; Placeholder value var temp4 = 2.5 ; Placeholder value var temp5 = 5 ; Set value above target value ; Message placeholder var consoleMessage1 = "N/A" M290 R0 S0 ; Clear babystepping ; LED status set global.sb_leds = "homing" ; ====================--------------------------------------------------------- ; Home all axes and lower the bed ; ==================== ; Make sure all axes are homed, and home Z again anyways if !move.axes[0].homed || !move.axes[1].homed || !move.axes[2].homed ; If axes aren't homed ; Home all axis G91 ; Relative positioning ; Lower currents, speed & accel M98 P"/sys/lib/current/xy_current_low.g" ; Set low XY currents M98 P"/sys/lib/current/z_current_low.g" ; Set low Z currents M98 P"/sys/lib/speed/speed_probing.g" ; Set low speed & accel ; Lower Z relative to current position if needed if !move.axes[2].homed ; If Z ain't homed G1 Z20 F9000 H1 ; Lower Z(bed) relative to current position elif move.axes[2].userPosition < 10 ; If Z is homed and less than 10 G1 Z20 F9000 ; Move to Z 10 ; Coarse home X or Y G1 X600 Y600 F2400 H1 ; Move quickly to X or Y endstop(first pass) ; Coarse home X G1 X600 H1 ; Move quickly to X endstop(first pass) ; Coarse home Y G1 Y600 H1 ; Move quickly to Y endstop(first pass) ; Move away from the endstops G1 X-5 Y-5 F9000 ; Go back a few mm ; Fine home X G1 X600 F360 H1 ; Move slowly to X axis endstop(second pass) ; Fine home Y G1 Y600 H1 ; move slowly to Y axis endstop(second pass) ; Absolute positioning G90 ; Absolute positioning ; Home Z ; Load the probe M400 ; Wait for moves to finish M98 P"/sys/lib/klicky/klicky_status.g" ; Refresh klicky status M401 P0 ; Load the klicky probe M400 ; Wait for moves to finish M98 P"/sys/lib/klicky/klicky_status.g" ; Refresh klicky status ; Last check to ensure klicky is attached if global.klicky_status = "attached" echo "Probe ATTACHED" else echo "Error probe not attached - aborting" M291 T5 R"Z Homing Aborted!" P"Z haven't been homed - check probe" abort ; Move to bed center and home Z M98 P"/sys/lib/goto/bed_center.g" ; Move to bed center M98 P"/sys/lib/speed/speed_probing.g" ; Set low speed & accel G30 K0 Z-99999 ; Probe the center of the bed else ; Home Z axis- ; Do nothing if XY is not homed yet if move.axes[0].homed && move.axes[1].homed M98 P"/sys/lib/current/z_current_low.g" ; Set low Z currents if !move.axes[2].homed ; If Z ain't homed G1 Z20 F9000 H1 ; Lower Z(bed) relative to current position elif move.axes[2].userPosition < 10 ; If Z is homed and less than 10 G1 Z20 F9000 ; Move to Z 10 ; Lower currents, speed & accel M98 P"/sys/lib/current/xy_current_low.g" ; Set low XY currents M98 P"/sys/lib/current/z_current_low.g" ; Set low Z currents M98 P"/sys/lib/speed/speed_probing.g" ; Set low speed & accel ; Load the probe M400 ; Wait for moves to finish M98 P"/sys/lib/klicky/klicky_status.g" ; Refresh klicky status M401 P0 ; Load the klicky probe M400 ; Wait for moves to finish M98 P"/sys/lib/klicky/klicky_status.g" ; Refresh klicky status ; Last check to ensure klicky is attached if global.klicky_status = "attached" echo "Probe ATTACHED" else echo "Error probe not attached - aborting" M291 T5 R"Z Homing Aborted!" P"Z haven't been homed - check probe" abort ; Move to bed center and home Z M98 P"/sys/lib/goto/bed_center.g" ; Move to bed center M98 P"/sys/lib/speed/speed_probing.g" ; Set low speed & accel G30 K0 Z-99999 ; Probe the center of the bed if move.axes[2].userPosition < 20 G1 Z20 F2400 ; Lower Z ; ====================--------------------------------------------------------- ; Calibrate klicky ; ==================== ; Position for probing G1 X{global.z_pin_x - 4} Y{global.z_pin_y - 23.5} F18000 ; Move the klicky body over the Z-pin G1 Z10 F2400 ; Move probe closer to z-pin ; Lower probing speed for accuracy M558 K1 F100:50 ; Lower probing speed ; Probe klicky body on Z-pin, minimum 0.004mm accuracy while var.temp2 >= 0.004 G30 K1 S-1 ; Probe the klicky body with the Z-pin and report value M400 ; Wait for moves to finish ; Lift from z-pin G91 ; Relative positioning G1 Z2 F500 ; Quickly move up 2mm G90 ; Absolute positioning M400 ; Wait for moves to finish ; Save first probe result set var.temp0 = sensors.probes[1].lastStopHeight ; Probe klicky body on Z-pin again G30 K1 S-1 ; Probe the klicky body with the Z-pin and report value M400 ; Wait for moves to finish ; Lift from z-pin G91 ; Relative positioning G1 Z2 F500 ; Quickly move up 2mm G90 ; Absolute positioning M400 ; Wait for moves to finish ; Save second probe result set var.temp1 = sensors.probes[1].lastStopHeight ;Calculate deviation set var.temp2 = (var.temp0-var.temp1) ; Calculate the new klicky offset var new_k0_offset = {((var.temp0 + var.temp1) / 2) + var.base_Hot_offset} ; Compensate for cold extruder if heat.heaters[1].current < 150 set var.new_k0_offset = {var.new_k0_offset + var.add_Cold_offset} ; Enable the new klicky offset G31 K0 Z{var.new_k0_offset} ; Apply the new Z offsett value ; Return standard probing speed M558 K1 F600:180 ; Reset probing speed to normal values ; Make a report message set var.consoleMessage1 = "Old Klicky offset " ^ var.old_k0_offset ^ " New Klicky offset " ^ var.new_k0_offset ; ====================--------------------------------------------------------- ; Calibrate Z-pin ; ==================== ; Check if Z-Pin calibration is enabled or not if var.calibrate_Z_Pin ; Message placeholder var consoleMessage2 = "N/A" ; Move bed away from nozzle G1 Z10 F2400 ; Lower the bed ; Position for probing M98 P"/sys/lib/goto/bed_center.g" ; Move to the center of the bed M400 ; Wait for moves to finish ; Lower probing speed for accuracy M558 K0 F100:50 ; Lower probing speed ; Probe the bed, minimum 0.004mm accuracy while var.temp5 >= 0.004 G30 K0 S-1 ; Probe the klicky body with the Z-pin and report value M400 ; Wait for moves to finish ; Lift from z-pin G91 ; Relative positioning G1 Z2 F500 ; Quickly move up 2mm G90 ; Absolute positioning M400 ; Wait for moves to finish ; Save first probe result set var.temp3 = sensors.probes[0].lastStopHeight ; Probe klicky body on Z-pin again G30 K0 S-1 ; Probe the klicky body with the Z-pin and report value M400 ; Wait for moves to finish ; Lift from z-pin G91 ; Relative positioning G1 Z2 F500 ; Quickly move up 2mm G90 ; Absolute positioning M400 ; Wait for moves to finish ; Save second probe result set var.temp4 = sensors.probes[0].lastStopHeight ;Calculate deviation set var.temp5 = (var.temp3-var.temp4) ; Calculate the new z-pin offset var new_k1_offset = {var.new_k0_offset - ((var.temp3 + var.temp4) / 2)} ; Enable the new z-pin offset G31 K1 Z{var.new_k1_offset} ; Apply the new Z offsett value ; Return standard probing speed M558 K0 F600:180 ; Reset probing speed to normal values ; Move bed away from nozzle G1 Z{global.klicky_clearance} F2400 ; Lower the bed ; Make a report message set var.consoleMessage2 = "Old Z-pin offset " ^ var.old_k1_offset ^ " New Z-pin offset " ^ var.new_k1_offset ; ====================--------------------------------------------------------- ; Finish up ; ==================== ; Save the new offsets M500 P10:31 ; Store the new Z offsett values to config-override.g G4 P250 ; Wait 250 milliseconds ; Lower bed to reduce pucker factor G1 Z20 F9000 ; Move to Z 20 ; Home z with the new offsets M98 P"/sys/lib/goto/bed_center.g" ; Move to bed center M98 P"/sys/lib/speed/speed_probing.g" ; Set low speed & accel G30 K0 Z-99999 ; Probe the center of the bed M400 ; Wait for moves to finish ; Report the new offsets ;K0 / klicky probe M118 P2 S{var.consoleMessage1} ; send used probe grid to paneldue M118 P3 S{var.consoleMessage1} ; send used probe grid to DWC console if var.calibrate_Z_Pin ;K1 / Z-pin M118 P2 S{var.consoleMessage2} ; send used probe grid to paneldue M118 P3 S{var.consoleMessage2} ; send used probe grid to DWC console set global.Z_cal = true ; Dock the probe M402 P0 ; Dock the klicky probe M400 ; Wait for moves to finish M98 P"/sys/lib/klicky/klicky_status.g" ; Refresh klicky status ; Full currents, speed & accel M98 P"/sys/lib/current/z_current_high.g" ; Restore normal Z currents M98 P"/sys/lib/current/xy_current_high.g" ; Set high XY currents M98 P"/sys/lib/speed/speed_printing.g" ; Restore normal speed & accels ; Lower Z(bed) after probing G90 ; Absolute positioning G1 Z5 F2400 ; Move to Z 5 ; Report whats going on M291 R"Z Offset Calibration" P"Done" T5 ; Bed leveling done message ;LED status set global.sb_leds = "ready"

I've also moved all the homing portion fully into the macro itself rather than calling for G28 or G28 Z that makes it "deploy" and "retract" the probe way to many times.

@mher

@M7460 you could add either an elif with the conditions where you want the error or just an else to capture everything that doesn't meet the if.
The something like M118 to post the message.
abort can be used to stop the run on a macro https://docs.duet3d.com/en/User_manual/Reference/Gcode_meta_commands#abort-command

@jay_s_uk said in How to park the last tool?:

T-1

It works. Thnks!

@chrishamm

Yeah sorry i meant to use "." BUT, that's not working 😶

The specific code i'm trying to run is:

; Printer is idle, new default mesh will be probed if state.status = "idle" ; printer is idle, new default mesh will be probed G29 S0 ; probe the bed, save height map to heightmap.csv and enable compensation G29 S3 P"default_heightmap.csv" ; Save the current height map to file "full_heightmap.csv" G29 S1 P"default_heightmap.csv" ; Load height map file "full_heightmap.csv" and enable mesh bed compensation elif state.status = "processing" ; printer is processing, new adaptive mesh will be probed G29 S0 ; probe the bed, save height map to heightmap.csv and enable compensation G29 S3 P"adaptive_heightmap.csv" ; Save the current height map to file "full_heightmap.csv" G29 S1 P"adaptive_heightmap.csv" ; Load height map file "full_heightmap.csv" and enable mesh bed compensation

It looks like i've found out where i did wrong, the state changes to "busy" when i start the macro. Changed "idle" to "busy" now and it seems to behaving like inteded!

@ApTix Thanks for reporting this, it will be fixed in the next version.

@IndeX4D

@IndeX4D said in "Universal" Tool Change Files (on steroids).:

@deckingman
Thank you

You are welcome. For info, I have now wrapped those files into macros which I have named "toolFree", "toolPost", and "toolPre" and which are in the .sys folder, rather than the macros folder. So every "tpre.n" simply calls the macro "toolFree" and likewise with tfre.n and tpost.n which makes things a lot tidier and much easier to edit a single file rather than multiple files should that be necessary.

@Phaedrux

You are right, I didn't even remember about this parameter. Thank you very much

14c952d1-eacc-4e48-8ba5-33e17c90271e-image.png

(RRF 3.5 and later only) Display a number of choices. The names of the choices are given by the K parameter as an array of strings.

3.5 hasn't be released yet.

@dc42
Alright it seems like i figured out what is causing the issue.

I created a new macro and started adding things one by one.
Everything went fine until I added this line:

G91 G1 H2 Z7 G90 ; Set to relative positioning, move Z up 5mm, change back to absolute positioning

after adding this the while loop kept on running. After removing it everything ran as expected again

EDIT:
just confirmed it by creating the following macro. This would just keep running the while loop infinite.

G91 G1 Z5 G90 ;Removed H2 to be sure this wasn't the cause while iterations < 4 echo "iteration: " ^ iterations

Then I split the G91/G90 command from single line to multi line and it started working as expected. So it seems there is an issue with the single line implementation for relative/absolute.
Which I read here we should be able to do the way I did
https://forum.duet3d.com/topic/11662/treat-g90-g91-and-m82-m83-like-g53/3

@OwenD said in Conditional code to purge after a period of time.:

..................That would only count layer changes, not retractions.

Of course it would - whatever was I thinking?

I'm afraid my brain and my fingers aren't always on speaking terms these days 🙂

My brain just doesn't work...........